update rps slider label #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dalthecow <[email protected]>
Closed
|
🧹 The live preview for this PR has been removed. |
sjmonson
approved these changes
Sep 4, 2025
tukwila
pushed a commit
to tukwila/guidellm
that referenced
this pull request
Sep 17, 2025
## Summary Fix for this issue: vllm-project#275 Updating RPS slider label phrasing since it wasn't totally accurate. Signed-off-by: dalthecow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for this issue:
#275
Updating RPS slider label phrasing since it wasn't totally accurate.